[HOTFIX] applying PR #6893 to release/2026-04-03#6894
Merged
Sicheng-Pan merged 1 commit intorelease/2026-04-03from Apr 11, 2026
Merged
[HOTFIX] applying PR #6893 to release/2026-04-03#6894Sicheng-Pan merged 1 commit intorelease/2026-04-03from
Sicheng-Pan merged 1 commit intorelease/2026-04-03from
Conversation
## Description of changes
_Summarize the changes made by this PR._
- Improvements & Bug fixes
- We recently changed get_prefix() to use buffered_unordered().
Previously it was join_all(). The assumption was that upstream callsites
don't expect results in sorted order of keys
- However, sparse writer expects its keys in order for e.g. when
computing the block maxes of a dimension; it does a
get_prefix(encoded_dim) and expects the block maxes to be in sorted
order of the block end offset id.
- Fixed by changing to buffered()
- New functionality
- ...
## Test plan
_How are these changes tested?_
- [x] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust
## Migration plan
_Are there any migrations, or any forwards/backwards compatibility
changes needed in order to make sure this change deploys reliably?_
## Observability plan
_What is the plan to instrument and monitor this change?_
## Documentation Changes
_Are all docstrings for user-facing APIs updated if required? Do we need
to make documentation changes in the_ [_docs
section](https://github.com/chroma-core/chroma/tree/main/docs/docs.trychroma.com)?_
---------
Co-authored-by: Sanket Kedia <sanketkedia@Sankets-MBP.hsd1.ca.comcast.net>
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks the commit 49e55d4 onto release/2026-04-03. If there are unresolved conflicts, please resolve them manually.