Skip to content

[HOTFIX] applying PR #6893 to release/2026-04-03#6894

Merged
Sicheng-Pan merged 1 commit intorelease/2026-04-03from
hotfix-6893/release/2026-04-03
Apr 11, 2026
Merged

[HOTFIX] applying PR #6893 to release/2026-04-03#6894
Sicheng-Pan merged 1 commit intorelease/2026-04-03from
hotfix-6893/release/2026-04-03

Conversation

@chroma-droid
Copy link
Copy Markdown

This PR cherry-picks the commit 49e55d4 onto release/2026-04-03. If there are unresolved conflicts, please resolve them manually.

## Description of changes

_Summarize the changes made by this PR._

- Improvements & Bug fixes
- We recently changed get_prefix() to use buffered_unordered().
Previously it was join_all(). The assumption was that upstream callsites
don't expect results in sorted order of keys
- However, sparse writer expects its keys in order for e.g. when
computing the block maxes of a dimension; it does a
get_prefix(encoded_dim) and expects the block maxes to be in sorted
order of the block end offset id.
    - Fixed by changing to buffered()
- New functionality
    - ...

## Test plan

_How are these changes tested?_

- [x] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust

## Migration plan

_Are there any migrations, or any forwards/backwards compatibility
changes needed in order to make sure this change deploys reliably?_

## Observability plan

_What is the plan to instrument and monitor this change?_

## Documentation Changes

_Are all docstrings for user-facing APIs updated if required? Do we need
to make documentation changes in the_ [_docs
section](https://github.com/chroma-core/chroma/tree/main/docs/docs.trychroma.com)?_

---------

Co-authored-by: Sanket Kedia <sanketkedia@Sankets-MBP.hsd1.ca.comcast.net>
@github-actions
Copy link
Copy Markdown

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@Sicheng-Pan Sicheng-Pan merged commit a782440 into release/2026-04-03 Apr 11, 2026
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants